feat(web): implement SearchCluster splitting 🚂 #15031
Open
+568
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
72798ba to
e5083de
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
8adec0a to
fe15157
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
4e17f64 to
8df54e8
Compare
jahorton
changed the base branch from
refactor/web/complex-search-space-reuse
to
change/web/track-righthand-split-index
jahorton
force-pushed
the
change/web/track-righthand-split-index
branch
from
e65ad7c to
5f1ce79
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
2989607 to
7e82b72
Compare
jahorton
changed the base branch from
change/web/track-righthand-split-index
to
refactor/web/complex-search-space-reuse
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
ef700d0 to
567ba68
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
7e82b72 to
6bbdb8d
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
567ba68 to
0286e3c
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
6bbdb8d to
39ac356
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
18c246a to
d98603f
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
0eddcf8 to
dadefba
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
eaac92f to
403721b
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
dadefba to
ec12918
Compare
jahorton
changed the base branch from
refactor/web/complex-search-space-reuse
to
change/web/add-same-edge-detection
jahorton
force-pushed
the
change/web/add-same-edge-detection
branch
2 times, most recently
from
bb2c119 to
e69bb62
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
ec12918 to
345c949
Compare
jahorton
force-pushed
the
change/web/add-same-edge-detection
branch
from
e69bb62 to
71df397
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
345c949 to
e3ce01f
Compare
jahorton
force-pushed
the
change/web/add-same-edge-detection
branch
from
71df397 to
1f4897f
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
e3ce01f to
d097728
Compare
jahorton
force-pushed
the
change/web/add-same-edge-detection
branch
from
1f4897f to
56d7a8f
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
d097728 to
c31523a
Compare
jahorton
changed the base branch from
change/web/add-same-edge-detection
to
feat/web/cluster-merging
jahorton
changed the title
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
c31523a to
8f7363d
Compare
jahorton
changed the base branch from
feat/web/cluster-merging
to
change/web/prepare-for-divergent-splits
Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
change/web/prepare-for-divergent-splits
branch
from
fccd35e to
4f1435c
Compare
jahorton
force-pushed
the
feat/web/cluster-splitting-and-merging
branch
from
8f7363d to
98d2043
Compare
jahorton
requested review from
ermshiperete and
mcdurdin
and removed request for
ermshiperete
ermshiperete
approved these changes
Feb 11, 2026
| // in its history, but it reconverges before the end. | ||
| assert.isTrue(cleanSplit[1] instanceof SearchQuotientSpur); | ||
| // Note that the path structures themselves, however, will be rebuilt - | ||
| // and with new spaceIDs.ß |
Contributor
There was a problem hiding this comment.
Suggested change
| // and with new spaceIDs.ß | |
| // and with new spaceIDs. |
| const cleanTail = seq.slice(splitIndex+1); | ||
|
|
||
| const splitSegment = seq[splitIndex]; | ||
| const segmentSplitIndex = splitSegment.codepointLength - splitLocation; |
Contributor
There was a problem hiding this comment.
Is this correct? search-quotient-spur.ts uses
const internalSplitIndex = charIndex - (this.codepointLength - this.insertLength);
so I'm wondering if this should be ?
Suggested change
| const segmentSplitIndex = splitSegment.codepointLength - splitLocation; | |
| const segmentSplitIndex = splitLocation - (splitSegment.codepointLength - splitSegment.insertLength); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves to implement
SearchQuotientCluster.split()in full, meeting the following criteria:- This requires (live) use of the
.isSameNode()method from feat(web): add isSameNode for duplicate quotient-node detection 🚂 #15478, which is designed to identify such cases. It thus is no longer unit-test only.- We must not group left-hand side paths (or right-hand side paths) that represent different subsets of the user's original keystrokes.
SearchQuotientClustertype should be leveraged for results where applicable - where two or more paths converge to the same total subset of keystroke input + codepoint length.Build-bot: skip build:web
Test-bot: skip